-
Notifications
You must be signed in to change notification settings - Fork 124
ARROW-13705: [Website] pin node version to 16 to allow CI and local dev parity #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 16 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,11 @@ webpacked_js = "javascript/main.js" | |
| installed_package_lock_json = "node_modules/.package-lock.json" | ||
|
|
||
| file installed_package_lock_json => ["package.json", "package-lock.json"] do | ||
| sh("npm", "install", "--no-save") | ||
| if production? | ||
| sh("npm", "ci") | ||
| else | ||
| sh("npm", "install", "--no-save") | ||
| end | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the difference of
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://docs.npmjs.com/cli/v7/commands/npm-ci#description
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. |
||
| end | ||
|
|
||
| file webpacked_js => ["_webpack/main.js", installed_package_lock_json] do | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed this in #141...