Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
- uses: actions/setup-node@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this in #141...

with:
bundler-cache: true
- uses: actions/setup-node@v2
with:
cache: "npm"
- name: Install dependencies
run: |
bundle install
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
16
6 changes: 5 additions & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ webpacked_js = "javascript/main.js"
installed_package_lock_json = "node_modules/.package-lock.json"

file installed_package_lock_json => ["package.json", "package-lock.json"] do
sh("npm", "install", "--no-save")
if production?
sh("npm", "ci")
else
sh("npm", "install", "--no-save")
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference of npm ci and npm install --no-save?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.npmjs.com/cli/v7/commands/npm-ci#description

This command is similar to npm install, except it's meant to be used in automated environments such as test platforms, continuous integration, and deployment -- or any situation where you want to make sure you're doing a clean install of your dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

end

file webpacked_js => ["_webpack/main.js", installed_package_lock_json] do
Expand Down
15 changes: 9 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"description": "The source of https://arrow.apache.org/.",
"private": true,
"scripts": {},
"engines": {
"node": ">=16"
},
"repository": {
"type": "git",
"url": "git+https://github.com/apache/arrow-site.git"
Expand Down