Skip to content

GH-695: [Website] Fix anchors on visual identity page#696

Merged
amoeba merged 2 commits intoapache:mainfrom
amoeba:minor/website-fix-visual-identity-anchors
Aug 21, 2025
Merged

GH-695: [Website] Fix anchors on visual identity page#696
amoeba merged 2 commits intoapache:mainfrom
amoeba:minor/website-fix-visual-identity-anchors

Conversation

@amoeba
Copy link
Copy Markdown
Member

@amoeba amoeba commented Aug 20, 2025

I think the recent markdown parser change made it so we can't do headers like this anymore,

# Design of the logo {#design}

This fixes the current rendering which has headers that look like this:

Design of the logo {#design}

and restores the internal document anchors. A better solution might be to look into a Jekyll plugin that automatically enables anchors on headers and ToCs.

Closes #695

@github-actions
Copy link
Copy Markdown

Preview URL: https://amoeba.github.io/arrow-site

If the preview URL doesn't work, you may forget to configure your fork repository for preview.
See https://github.com/apache/arrow-site/blob/main/README.md#forks how to configure.

@lidavidm
Copy link
Copy Markdown
Member

Kou filed #695 for this, yeah

Copy link
Copy Markdown
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other pages that use this?

@amoeba
Copy link
Copy Markdown
Member Author

amoeba commented Aug 21, 2025

Kou filed #695 for this, yeah

Thanks, I missed that. I grepped for {# and didn't see other uses.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

It may be better that we generate Table of Contents automatically. There is no suitable feature for Jekyll... I may create something later.

Let's use this approach for now.

Comment thread visual_identity.md Outdated
@kou kou changed the title MINOR: [Website] Fix anchors on visual identity page GH-695: [Website] Fix anchors on visual identity page Aug 21, 2025
@amoeba amoeba merged commit 19aa5ae into apache:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom anchor doesn't work with jekyll-commonmark

3 participants