GH-695: [Website] Fix anchors on visual identity page#696
Merged
amoeba merged 2 commits intoapache:mainfrom Aug 21, 2025
Merged
GH-695: [Website] Fix anchors on visual identity page#696amoeba merged 2 commits intoapache:mainfrom
amoeba merged 2 commits intoapache:mainfrom
Conversation
|
Preview URL: https://amoeba.github.io/arrow-site If the preview URL doesn't work, you may forget to configure your fork repository for preview. |
Member
|
Kou filed #695 for this, yeah |
lidavidm
approved these changes
Aug 20, 2025
Member
lidavidm
left a comment
There was a problem hiding this comment.
Are there any other pages that use this?
Member
Author
Thanks, I missed that. I grepped for |
kou
approved these changes
Aug 21, 2025
Member
kou
left a comment
There was a problem hiding this comment.
+1
It may be better that we generate Table of Contents automatically. There is no suitable feature for Jekyll... I may create something later.
Let's use this approach for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the recent markdown parser change made it so we can't do headers like this anymore,
This fixes the current rendering which has headers that look like this:
and restores the internal document anchors. A better solution might be to look into a Jekyll plugin that automatically enables anchors on headers and ToCs.
Closes #695