Skip to content

[JS] Fix typings consuming apache-arrow module when noImplicitAny is false #17895

@asfimport

Description

@asfimport

The TypeScript compiler has a few bugs that raise compiler errors when valid strict-mode code is compiled with some of the strict mode-settings disabled. Since we ship the TS source code in the main apache-arrow npm module, consumers will encounter the following TypeScript compiler errors under these conditions:

# --strictNullChecks=true, --noImplicitAny=false
vector/numeric.ts(57,17): error TS2322: Type 'number' is not assignable to type 'never'.
vector/numeric.ts(61,35): error TS2322: Type 'number' is not assignable to type 'never'.
vector/numeric.ts(63,18): error TS2322: Type '0' is not assignable to type 'never'.
vector/virtual.ts(98,38): error TS2345: Argument of type 'TypedArray' is not assignable to parameter of type 'never'.

The fixes are minor, and I'll add a step in the unit tests to validate the build targets compile with different compilation flags than ours.

Related:
ReactiveX/IxJS#167
microsoft/TypeScript#20299

Reporter: Paul Taylor / @trxcllnt
Assignee: Paul Taylor / @trxcllnt

Note: This issue was originally created as ARROW-1903. Please see the migration documentation for further details.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions