Skip to content

[C++] See if stream alignment logic can be simplified #19216

@asfimport

Description

@asfimport

There were a couple patches related to 64-byte alignment for tensor messages at the beginning of April that I've been concerned about:

ARROW-2308: 26bc4ab#diff-bf4eb56f3cb806c32f60ae67afbb1bf0

ARROW-2437: 0f87c12

In my opinion, the alignment issue should be encapsulated in the protocol if possible; to have argument that toggles whether the file is to be aligned after reading the metadata seems wrong to me. The bytes written for alignment purposes should be accounted for in the metadata size prefix in the IPC message.

Since there are unit tests for this, I'd like to take a look and see if I can improve this without breaking the tests.

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

Note: This issue was originally created as ARROW-2840. Please see the migration documentation for further details.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions