[C++] Logical boolean kernels in kernels/boolean.cc cannot write into preallocated memory

[asfimport]

Reporter: Wes McKinney / @wesm
Assignee: Micah Kornfield / @emkornfield

Subtasks:

• [C++] Refactor memory allocation from InvertKernel
• [C++] Expose bit-util methods for binary boolean operations that don't allocate

PRs and other links:

• GitHub Pull Request #3287
• GitHub Pull Request #3731

_{Note: This issue was originally created as ARROW-3133. Please see the migration documentation for further details.}

[asfimport]

Micah Kornfield / @emkornfield:
is the issue this is trying to address the hard-coded:

out->value = ArrayData::Make(boolean(), right_data.length)?

 

Is the fix to check if the output already has an array >= appropriate size and use that instead?

[asfimport]

Wes McKinney / @wesm:
No, there is unavoidable memory allocation in all of the kernels:

• InvertKernel: https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/boolean.cc#L64

• Binary: https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/boolean.cc#L100

• And: https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/boolean.cc#L116

  etc.

  this needs to be refactored to decouple memory allocation from kernel invocation

[asfimport]

Micah Kornfield / @emkornfield:
Missed those. If this isn't urgent I can take a look at fixing this. I
will have only a few hours per week to work on it so progress might be a
liitle slow.

On Wednesday, December 26, 2018, Wes McKinney (JIRA) jira@apache.org

[asfimport]

Wes McKinney / @wesm:
It's not urgent so feel free to have a hack at it. You can also break the task into smaller pieces / PRs if you like

[asfimport]

Wes McKinney / @wesm:
Issue resolved by pull request 3287
#3287

[asfimport]

Micah Kornfield / @emkornfield:
reopening because the PR only fixed a sub-issue.

[asfimport]

Wes McKinney / @wesm:
Issue resolved by pull request 3731
#3731