[C++] Add short-circuit version of logical Status AND

[asfimport]

Status overloads the & operator as in (from file_base.cc):

finished_.MarkFinished(dw_status & finish_st & tg_status);

However, it also sometimes used as (from scalar.cc):

return StdHash(s.value.days) & StdHash(s.value.milliseconds);

This latter form is technically correct (in this case) because StdHash has no side effects and there is no real need to short-circuit. However, this can be very misleading. The compiler is allowed to reorder these statements as it wants. This led to trouble in #13232 because I suggested something like...

return Foo(value) & Bar(std::move(value));

Now, for a C++ expert, this may have been immediately obvious. However, I think we can simplify things by adding the && operator for Status to allow:

return Foo(value) && Bar(std::move(value));

Reporter: Weston Pace / @westonpace

PRs and other links:

• GitHub Pull Request #13304

_{Note: This issue was originally created as ARROW-16743. Please see the migration documentation for further details.}

[github-actions]

This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.