-
Notifications
You must be signed in to change notification settings - Fork 4k
Open
Description
Describe the bug, including details regarding any error messages, version, and platform.
The following issue:
Introduced a workaround to std::bit_width using std::log2p1 but this seems to be unavailable on test-ubuntu-22.04-cpp-emscripten:
[98/1092] Building CXX object src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o
FAILED: src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o
/usr/local/bin/sccache /root/emsdk/upstream/emscripten/em++ -DARROW_EXTRA_ERROR_CONTEXT -DARROW_WITH_TIMING_TESTS -DBOOST_ALL_NO_LIB -DBOOST_MPL_CFG_NO_PREPROCESSED_HEADERS -DBOOST_MP_STANDALONE=1 -DURI_STATIC_BUILD -I/build/cpp/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -I/build/cpp/_deps/lz4-src/build/cmake/../../lib -isystem /build/cpp/_deps/boost-src/libs/headers/include -isystem /build/cpp/_deps/boost-src/libs/algorithm/include -isystem /build/cpp/_deps/boost-src/libs/array/include -isystem /build/cpp/_deps/boost-src/libs/assert/include -isystem /build/cpp/_deps/boost-src/libs/config/include -isystem /build/cpp/_deps/boost-src/libs/static_assert/include -isystem /build/cpp/_deps/boost-src/libs/throw_exception/include -isystem /build/cpp/_deps/boost-src/libs/bind/include -isystem /build/cpp/_deps/boost-src/libs/core/include -isystem /build/cpp/_deps/boost-src/libs/concept_check/include -isystem /build/cpp/_deps/boost-src/libs/preprocessor/include -isystem /build/cpp/_deps/boost-src/libs/type_traits/include -isystem /build/cpp/_deps/boost-src/libs/exception/include -isystem /build/cpp/_deps/boost-src/libs/smart_ptr/include -isystem /build/cpp/_deps/boost-src/libs/tuple/include -isystem /build/cpp/_deps/boost-src/libs/function/include -isystem /build/cpp/_deps/boost-src/libs/iterator/include -isystem /build/cpp/_deps/boost-src/libs/detail/include -isystem /build/cpp/_deps/boost-src/libs/fusion/include -isystem /build/cpp/_deps/boost-src/libs/container_hash/include -isystem /build/cpp/_deps/boost-src/libs/describe/include -isystem /build/cpp/_deps/boost-src/libs/mp11/include -isystem /build/cpp/_deps/boost-src/libs/function_types/include -isystem /build/cpp/_deps/boost-src/libs/mpl/include -isystem /build/cpp/_deps/boost-src/libs/predef/include -isystem /build/cpp/_deps/boost-src/libs/utility/include -isystem /build/cpp/_deps/boost-src/libs/io/include -isystem /build/cpp/_deps/boost-src/libs/typeof/include -isystem /build/cpp/_deps/boost-src/libs/functional/include -isystem /build/cpp/_deps/boost-src/libs/optional/include -isystem /build/cpp/_deps/boost-src/libs/range/include -isystem /build/cpp/_deps/boost-src/libs/conversion/include -isystem /build/cpp/_deps/boost-src/libs/regex/include -isystem /build/cpp/_deps/boost-src/libs/unordered/include -isystem /build/cpp/_deps/boost-src/libs/align/include -isystem /build/cpp/_deps/boost-src/libs/crc/include -isystem /build/cpp/_deps/boost-src/libs/scope/include -isystem /build/cpp/_deps/boost-src/libs/scope_exit/include -isystem /build/cpp/_deps/boost-src/libs/system/include -isystem /build/cpp/_deps/boost-src/libs/variant2/include -isystem /build/cpp/_deps/boost-src/libs/winapi/include -isystem /build/cpp/_deps/boost-src/libs/tokenizer/include -isystem /build/cpp/_deps/boost-src/libs/uuid/include -isystem /build/cpp/_deps/boost-src/libs/numeric/conversion/include -isystem /build/cpp/_deps/boost-src/libs/multiprecision/include -isystem /build/cpp/brotli_ep/src/brotli_ep-install/include -isystem /build/cpp/snappy_ep/src/snappy_ep-install/include -isystem /build/cpp/rapidjson_ep/src/rapidjson_ep-install/include -isystem /build/cpp/zstd_ep-install/include -Qunused-arguments -fcolor-diagnostics -fPIC -fexceptions -Wno-error=deprecated-literal-operator -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wno-shorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -Werror -g2 -O1 -std=c++20 -fPIC -MD -MT src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o -MF src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o.d -o src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o -c /arrow/cpp/src/arrow/util/value_parsing.cc
In file included from /arrow/cpp/src/arrow/util/value_parsing.cc:20:
In file included from /arrow/cpp/src/arrow/util/value_parsing.h:32:
In file included from /arrow/cpp/src/arrow/type_traits.h:26:
/arrow/cpp/src/arrow/util/bit_util.h:145:15: error: no member named 'log2p1' in namespace 'std'
145 | return std::log2p1(x - 1);
| ~~~~~^
1 error generated.
em++: error: '/root/emsdk/upstream/bin/clang++ -target wasm32-unknown-emscripten -fvisibility=default -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-cxx-exceptions -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr -DEMSCRIPTEN --sysroot=/root/emsdk/upstream/emscripten/cache/sysroot -Xclang -iwithsysroot/include/fakesdl -Xclang -iwithsysroot/include/compat -x c++ -c -I/build/cpp/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -I/build/cpp/_deps/lz4-src/build/cmake/../../lib -isystem /build/cpp/_deps/boost-src/libs/headers/include -isystem /build/cpp/_deps/boost-src/libs/algorithm/include -isystem /build/cpp/_deps/boost-src/libs/array/include -isystem /build/cpp/_deps/boost-src/libs/assert/include -isystem /build/cpp/_deps/boost-src/libs/config/include -isystem /build/cpp/_deps/boost-src/libs/static_assert/include -isystem /build/cpp/_deps/boost-src/libs/throw_exception/include -isystem /build/cpp/_deps/boost-src/libs/bind/include -isystem /build/cpp/_deps/boost-src/libs/core/include -isystem /build/cpp/_deps/boost-src/libs/concept_check/include -isystem /build/cpp/_deps/boost-src/libs/preprocessor/include -isystem /build/cpp/_deps/boost-src/libs/type_traits/include -isystem /build/cpp/_deps/boost-src/libs/exception/include -isystem /build/cpp/_deps/boost-src/libs/smart_ptr/include -isystem /build/cpp/_deps/boost-src/libs/tuple/include -isystem /build/cpp/_deps/boost-src/libs/function/include -isystem /build/cpp/_deps/boost-src/libs/iterator/include -isystem /build/cpp/_deps/boost-src/libs/detail/include -isystem /build/cpp/_deps/boost-src/libs/fusion/include -isystem /build/cpp/_deps/boost-src/libs/container_hash/include -isystem /build/cpp/_deps/boost-src/libs/describe/include -isystem /build/cpp/_deps/boost-src/libs/mp11/include -isystem /build/cpp/_deps/boost-src/libs/function_types/include -isystem /build/cpp/_deps/boost-src/libs/mpl/include -isystem /build/cpp/_deps/boost-src/libs/predef/include -isystem /build/cpp/_deps/boost-src/libs/utility/include -isystem /build/cpp/_deps/boost-src/libs/io/include -isystem /build/cpp/_deps/boost-src/libs/typeof/include -isystem /build/cpp/_deps/boost-src/libs/functional/include -isystem /build/cpp/_deps/boost-src/libs/optional/include -isystem /build/cpp/_deps/boost-src/libs/range/include -isystem /build/cpp/_deps/boost-src/libs/conversion/include -isystem /build/cpp/_deps/boost-src/libs/regex/include -isystem /build/cpp/_deps/boost-src/libs/unordered/include -isystem /build/cpp/_deps/boost-src/libs/align/include -isystem /build/cpp/_deps/boost-src/libs/crc/include -isystem /build/cpp/_deps/boost-src/libs/scope/include -isystem /build/cpp/_deps/boost-src/libs/scope_exit/include -isystem /build/cpp/_deps/boost-src/libs/system/include -isystem /build/cpp/_deps/boost-src/libs/variant2/include -isystem /build/cpp/_deps/boost-src/libs/winapi/include -isystem /build/cpp/_deps/boost-src/libs/tokenizer/include -isystem /build/cpp/_deps/boost-src/libs/uuid/include -isystem /build/cpp/_deps/boost-src/libs/numeric/conversion/include -isystem /build/cpp/_deps/boost-src/libs/multiprecision/include -isystem /build/cpp/brotli_ep/src/brotli_ep-install/include -isystem /build/cpp/snappy_ep/src/snappy_ep-install/include -isystem /build/cpp/rapidjson_ep/src/rapidjson_ep-install/include -isystem /build/cpp/zstd_ep-install/include -MD -MF src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o.d -MT src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o -DARROW_EXTRA_ERROR_CONTEXT -DARROW_WITH_TIMING_TESTS -DBOOST_ALL_NO_LIB -DBOOST_MPL_CFG_NO_PREPROCESSED_HEADERS -DBOOST_MP_STANDALONE=1 -DURI_STATIC_BUILD -Qunused-arguments -fcolor-diagnostics -fPIC -fexceptions -Wno-error=deprecated-literal-operator -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wno-shorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -Werror -g0 -O1 -std=c++20 -fPIC /arrow/cpp/src/arrow/util/value_parsing.cc -o src/arrow/CMakeFiles/arrow_util.dir/util/value_parsing.cc.o' failed (returned 1)
[99/1092] Building CXX object src/arrow/CMakeFiles/arrow_util.dir/util/compression_lz4.cc.o
FAILED: src/arrow/CMakeFiles/arrow_util.dir/util/compression_lz4.cc.o
/usr/local/bin/sccache /root/emsdk/upstream/emscripten/em++ -DARROW_EXTRA_ERROR_CONTEXT -DARROW_WITH_TIMING_TESTS -DBOOST_ALL_NO_LIB -DBOOST_MPL_CFG_NO_PREPROCESSED_HEADERS -DBOOST_MP_STANDALONE=1 -DURI_STATIC_BUILD -I/build/cpp/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -I/build/cpp/_deps/lz4-src/build/cmake/../../lib -isystem /build/cpp/_deps/boost-src/libs/headers/include -isystem /build/cpp/_deps/boost-src/libs/algorithm/include -isystem /build/cpp/_deps/boost-src/libs/array/include -isystem /build/cpp/_deps/boost-src/libs/assert/include -isystem /build/cpp/_deps/boost-src/libs/config/include -isystem /build/cpp/_deps/boost-src/libs/static_assert/include -isystem /build/cpp/_deps/boost-src/libs/throw_exception/include -isystem /build/cpp/_deps/boost-src/libs/bind/include -isystem /build/cpp/_deps/boost-src/libs/core/include -isystem /build/cpp/_deps/boost-src/libs/concept_check/include -isystem /build/cpp/_deps/boost-src/libs/preprocessor/include -isystem /build/cpp/_deps/boost-src/libs/type_traits/include -isystem /build/cpp/_deps/boost-src/libs/exception/include -isystem /build/cpp/_deps/boost-src/libs/smart_ptr/include -isystem /build/cpp/_deps/boost-src/libs/tuple/include -isystem /build/cpp/_deps/boost-src/libs/function/include -isystem /build/cpp/_deps/boost-src/libs/iterator/include -isystem /build/cpp/_deps/boost-src/libs/detail/include -isystem /build/cpp/_deps/boost-src/libs/fusion/include -isystem /build/cpp/_deps/boost-src/libs/container_hash/include -isystem /build/cpp/_deps/boost-src/libs/describe/include -isystem /build/cpp/_deps/boost-src/libs/mp11/include -isystem /build/cpp/_deps/boost-src/libs/function_types/include -isystem /build/cpp/_deps/boost-src/libs/mpl/include -isystem /build/cpp/_deps/boost-src/libs/predef/include -isystem /build/cpp/_deps/boost-src/libs/utility/include -isystem /build/cpp/_deps/boost-src/libs/io/include -isystem /build/cpp/_deps/boost-src/libs/typeof/include -isystem /build/cpp/_deps/boost-src/libs/functional/include -isystem /build/cpp/_deps/boost-src/libs/optional/include -isystem /build/cpp/_deps/boost-src/libs/range/include -isystem /build/cpp/_deps/boost-src/libs/conversion/include -isystem /build/cpp/_deps/boost-src/libs/regex/include -isystem /build/cpp/_deps/boost-src/libs/unordered/include -isystem /build/cpp/_deps/boost-src/libs/align/include -isystem /build/cpp/_deps/boost-src/libs/crc/include -isystem /build/cpp/_deps/boost-src/libs/scope/include -isystem /build/cpp/_deps/boost-src/libs/scope_exit/include -isystem /build/cpp/_deps/boost-src/libs/system/include -isystem /build/cpp/_deps/boost-src/libs/variant2/include -isystem /build/cpp/_deps/boost-src/libs/winapi/include -isystem /build/cpp/_deps/boost-src/libs/tokenizer/include -isystem /build/cpp/_deps/boost-src/libs/uuid/include -isystem /build/cpp/_deps/boost-src/libs/numeric/conversion/include -isystem /build/cpp/_deps/boost-src/libs/multiprecision/include -isystem /build/cpp/brotli_ep/src/brotli_ep-install/include -isystem /build/cpp/snappy_ep/src/snappy_ep-install/include -isystem /build/cpp/rapidjson_ep/src/rapidjson_ep-install/include -isystem /build/cpp/zstd_ep-install/include -Qunused-arguments -fcolor-diagnostics -fPIC -fexceptions -Wno-error=deprecated-literal-operator -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wno-shorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -Werror -g2 -O1 -std=c++20 -fPIC -MD -MT src/arrow/CMakeFiles/arrow_util.dir/util/compression_lz4.cc.o -MF src/arrow/CMakeFiles/arrow_util.dir/util/compression_lz4.cc.o.d -o src/arrow/CMakeFiles/arrow_util.dir/util/compression_lz4.cc.o -c /arrow/cpp/src/arrow/util/compression_lz4.cc
In file included from /arrow/cpp/src/arrow/util/compression_lz4.cc:30:
/arrow/cpp/src/arrow/util/bit_util.h:145:15: error: no member named 'log2p1' in namespace 'std'
145 | return std::log2p1(x - 1);
| ~~~~~^
1 error generated.
Component(s)
C++, Continuous Integration
Reactions are currently unavailable