[R][CI] rhub/ubuntu-clang fails on missing libpng

[rok]

Describe the bug, including details regarding any error messages, version, and platform.

test-r-linux-as-cran is failing in the rhub/ubuntu-clang matrix job.

png.h file not found
libpng-config: command not found

Proposed diff:

diff --git a/ci/scripts/r_install_system_dependencies.sh b/ci/scripts/r_install_system_dependencies.sh
@@
-    apt-get install -y libcurl4-openssl-dev libssl-dev libuv1-dev
+    apt-get install -y libcurl4-openssl-dev libpng-dev libssl-dev libuv1-dev

Component(s)

R

[kou]

The error isn't a real problem of the job failure because the error is ignored.

The real problem is https://github.com/ursacomputing/crossbow/actions/runs/28486931252/job/84435314002#step:6:1782 :

In file included from /arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/cpp/src/parquet/column_reader.cc:46:
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/cpp/src/arrow/util/rle_encoding_internal.h:814:24: error: missing 'typename' prior to dependent type name 'RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type'
    using RunDecoder = RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type;
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                       typename 

Anyway, we should fix the libpng related problem.

[raulcd]

Should we merge the libpng-dev addition and create a new issue for the RleBitPackedDecoderGetRunDecoder error? This should be fixed for the 25.0.0 release, right?

[ 87%] Building CXX object src/parquet/CMakeFiles/parquet_objlib.dir/encoder.cc.o
In file included from /arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/cpp/src/parquet/decoder.cc:47:
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/cpp/src/arrow/util/rle_encoding_internal.h:814:24: error: missing 'typename' prior to dependent type name 'RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type'
    using RunDecoder = RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type;
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                       typename 
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/cpp/src/arrow/util/rle_encoding_internal.h:1127:24: error: missing 'typename' prior to dependent type name 'RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type'
    using RunDecoder = RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type;
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                       typename 
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/cpp/src/arrow/util/rle_encoding_internal.h:1309:24: error: missing 'typename' prior to dependent type name 'RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type'
    using RunDecoder = RleBitPackedDecoderGetRunDecoder<value_type, decltype(run)>::type;
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                       typename 
3 errors generated.

@pitrou @AntoinePrv

[pitrou]

Yes, we should create a new issue for the RleBitPackedDecoderGetRunDecoder error.

[AntoinePrv]

On it. This typename madness should have been improved with C++20 but apparently not every compiler has the same C++20

[raulcd]

I've created the following issue and have marked as a blocker for 25.0.0.

• [C++][R][Parquet] test-r-linux-as-cran fails building due to missing 'typename' prior to dependent type name 'RleBitPackedDecoderGetRunDecode ' #50330

[raulcd]

Issue resolved by pull request 50328
#50328