ARROW-12563: [C++][Gandiva] Add space,add_months and datediff functions for string #10160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
DileepSrigiri
changed the title
projjal
reviewed
May 5, 2021
DileepSrigiri
force-pushed
the
Add-space-addmonths-datediff-function
branch
2 times, most recently
from
1bef787 to
8a91fe3
Compare
projjal
reviewed
May 11, 2021
Contributor
There was a problem hiding this comment.
nit: better pass date::year_month_day as argument
Contributor
There was a problem hiding this comment.
you can set a static days_in_month array
Contributor
|
Can you add a description comment in the PR about the functions. |
DileepSrigiri
force-pushed
the
Add-space-addmonths-datediff-function
branch
from
8a91fe3 to
9b9027f
Compare
Contributor
|
The CI builds are failing. |
DileepSrigiri
force-pushed
the
Add-space-addmonths-datediff-function
branch
4 times, most recently
from
c619a1f to
32ee17c
Compare
DileepSrigiri
force-pushed
the
Add-space-addmonths-datediff-function
branch
from
32ee17c to
11eec9a
Compare
projjal
approved these changes
May 13, 2021
Contributor
Author
|
Functions were already added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space(int n): Return a string of n spaces
add_months(string start_date, int num_months): adds num_months to start_date and returns that date
datediff(string enddate, string startdate): Returns the number of days from startdate to enddate