ARROW-1438: [Python] Pull serialization context through PlasmaClient put and get #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
requested changes
Aug 31, 2017
|
|
||
| def put(self, object value, ObjectID object_id=None): | ||
| def put(self, object value, ObjectID object_id=None, | ||
| serialization_context=None): |
Member
There was a problem hiding this comment.
Could you the type to the new parameter?
Member
There was a problem hiding this comment.
I believe it can be any Python object having the required methods
Contributor
Author
There was a problem hiding this comment.
Yes, this is true!
wesm
reviewed
Aug 31, 2017
|
|
||
| def put(self, object value, ObjectID object_id=None): | ||
| def put(self, object value, ObjectID object_id=None, | ||
| serialization_context=None): |
Member
There was a problem hiding this comment.
I believe it can be any Python object having the required methods
Contributor
Author
|
Good catch, I'm adding the tests! |
pcmoritz
force-pushed
the
plasma-serialization-context
branch
from
63ff3cd to
1a4fade
Compare
Contributor
Author
|
+1 This should now be ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.