Skip to content

ARROW-1450: [Python] Raise proper error if custom serialization handler fails #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcmoritz wants to merge 4 commits into from
Closed

ARROW-1450: [Python] Raise proper error if custom serialization handler fails #1029

pcmoritz wants to merge 4 commits into from

Conversation

@pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Sep 2, 2017 •
edited
Loading

This fixes the serialize and deserialize methods to throw the right exceptions.

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Sep 3, 2017

+1 This can be merged, if desired we can fix the following TODO in arrow/python/common.h as a followup:

TODO(wesm): We can just let errors pass through. To be explored later

wesm
wesm approved these changes Sep 3, 2017
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @pcmoritz!

@asfgit asfgit closed this in 016c45a Sep 3, 2017
@wesm wesm deleted the pyarrow-serialization-error branch September 3, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcmoritz @wesm