ARROW-13783. [Python] Preview data when printing tables #11028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amol-
commented
Aug 30, 2021
cpp/src/arrow/pretty_print.cc
Outdated
Member
Author
There was a problem hiding this comment.
This is to fix a bug in printing arrays that lead to
[10,20,30,40 ]
instead of
[10,20,30,40]
when skip_new_lines=True
pitrou
reviewed
Sep 13, 2021
pitrou
requested changes
Oct 4, 2021
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thanks for this PR!
- Can you rebase on master?
- Here are some comments.
Member
Author
|
@pitrou I should have addressed all your comments |
| c0: int16 | ||
| c1: int32 | ||
| ---- | ||
| c0: [[1,2,3,4]] |
Member
There was a problem hiding this comment.
Late comment: I initially found those double square brackets quite confusing (why are there double brackets? Is it a list array of one element?)
(I understand this this is because each column is a ChunkedArray (and the string formatting is coming from there), and so you can have multiple chunks in the column. So also not necessarily something that can be done about this)
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Closes apache#11028 from amol-/ARROW-13783 Authored-by: Alessandro Molina <amol@turbogears.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.