Skip to content

Conversation

@zeroshade
Copy link
Member

Corresponds to #11149 which fixes the same issue in the C++ implementation, this fixes it in the Go implementation which had the same problem due to porting from the C++.

CC @emkornfield @sunchao

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@zeroshade zeroshade changed the title PARQUET-2092: [Go] Fix file offsets in go impl ARROW-13996: [Go][Parquet] Fix file offsets in go impl Sep 14, 2021
@github-actions
Copy link

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @zeroshade !

@zeroshade zeroshade deleted the file_offsets branch September 27, 2021 17:13
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
Corresponds to apache#11149 which fixes the same issue in the C++ implementation, this fixes it in the Go implementation which had the same problem due to porting from the C++.

CC @emkornfield @sunchao

Closes apache#11153 from zeroshade/file_offsets

Lead-authored-by: Matt Topol <zotthewizard@gmail.com>
Co-authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants