Skip to content

ARROW-14057: [C++] Bump aws-c-common version #11203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonkeane wants to merge 1 commit into from
Closed

ARROW-14057: [C++] Bump aws-c-common version #11203

jonkeane wants to merge 1 commit into from

Conversation

@jonkeane
Copy link
Member

@jonkeane jonkeane commented Sep 21, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 21, 2021

https://issues.apache.org/jira/browse/ARROW-14057

@github-actions
Copy link

github-actions bot commented Sep 21, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou
Copy link
Member

pitrou commented Sep 21, 2021

@github-actions crossbow submit -g cpp

pitrou
pitrou approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the principle. Let's ensure CI builds pass.

@github-actions
Copy link

github-actions bot commented Sep 21, 2021

Revision: ec643a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-851

Task Status
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp Github Actions
test-fedora-33-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions

@jonkeane
Copy link
Member Author

jonkeane commented Sep 21, 2021

The thread sanitizer failure is https://github.com/ursacomputing/crossbow/runs/3665866336?check_suite_focus=true#step:7:4108:

[  FAILED  ] 1 test, listed below:
[  FAILED  ] AsyncReaderTests.InvalidRowsSkipped

 1 FAILED TEST
ThreadSanitizer: reported 1 warnings
ThreadSanitizer or leak check failures in /build/cpp/build/test-logs/arrow-csv-test.txt
/build/cpp/src/arrow/csv

It looks like S3 isn't even built for this build https://github.com/ursacomputing/crossbow/runs/3665866336?check_suite_focus=true#step:7:2025, could this be unrelated?

@westonpace
Copy link
Member

westonpace commented Sep 21, 2021

The AsyncReaderTests.InvalidRowsSkipped is addressed in #11198 / ARROW-14053

@jonkeane jonkeane closed this in 8a1da8a Sep 21, 2021
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
@jonkeane @ViniciusSouzaRoque
ARROW-14057: [C++] Bump aws-c-common version
f70409d 
Closes apache#11203 from jonkeane/ARROW-14057

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@asfimport asfimport mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane @pitrou @westonpace