Skip to content

ARROW-13947: [C++] Support more types in index kernel #11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lidavidm wants to merge 2 commits into from
Closed

ARROW-13947: [C++] Support more types in index kernel #11370

lidavidm wants to merge 2 commits into from

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Oct 8, 2021

Also clarify the behavior for nulls in the docs.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

https://issues.apache.org/jira/browse/ARROW-13947

cyb70289
cyb70289 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

pitrou
pitrou approved these changes Oct 12, 2021
View reviewed changes
cpp/src/arrow/compute/kernels/aggregate_test.cc Outdated
Copy link
Member

@pitrou pitrou Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, what happens if the index scalar type doesn't match the input array type? Is it tested somewhere?

Copy link
Member Author

@lidavidm lidavidm Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it doesn't seem to be checked anywhere. I'll fix this when I get a chance.

Copy link
Member Author

@lidavidm lidavidm Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added checks for mismatched type and for shared_ptr being nullptr.

@lidavidm lidavidm closed this in 81fb955 Oct 26, 2021
@lidavidm lidavidm deleted the arrow-13947 branch October 26, 2021 18:08
@ursabot
Copy link

ursabot commented Oct 26, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 1cba1cc and contender = 81fb955. 81fb955 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.31% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

@cyb70289 cyb70289 cyb70289 approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lidavidm @ursabot @pitrou @cyb70289