Skip to content

ARROW-1543: [C++] Correct C++ tutorial to use std::unique_ptr instead of std::shared_ptr #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 3 commits into from
Closed

ARROW-1543: [C++] Correct C++ tutorial to use std::unique_ptr instead of std::shared_ptr #1157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df6dd2
Correct C++ tutorial to use std::unique_ptr instead of std::shared_ptr
wesm Oct 4, 2017
8afcc60
Tweaks
wesm Oct 4, 2017
82e7593
Add missing namespace
wesm Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions cpp/apidoc/tutorials/row_wise_conversion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,15 @@ is referenced by the offsets in the former array.
// the underlying memory regions in-place. At the moment, arrow::jemalloc is only
// supported on Unix systems, not Windows.

arrow::Int64Builder id_builder(arrow::default_memory_pool());
arrow::DoubleBuilder cost_builder(arrow::default_memory_pool());
std::shared_ptr<DoubleBuilder> components_values_builder =
std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
arrow::ListBuilder components_builder(arrow::default_memory_pool(),
components_values_builder);
using arrow::DoubleBuilder;
using arrow::Int64Builder;
using arrow::ListBuilder;

arrow::MemoryPool* pool = arrow::default_memory_pool();
Int64Builder id_builder(pool);
DoubleBuilder cost_builder(pool);
std::unique_ptr<DoubleBuilder> components_values_builder(new DoubleBuilder(pool));
ListBuilder components_builder(pool, std::move(components_values_builder));
```

Now we can loop over our existing data and insert it into the builders. The
Expand Down