Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Oct 17, 2017

garrow_record_batch_reader_read_next_record_batch() is deprecated.
It's for following C++ API change.

garrow_record_batch_reader_read_next_record_batch() is deprecated.
It's for following C++ API change.
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm
Copy link
Member

wesm commented Oct 17, 2017

@kou can you update the JIRA number to 1679?

@wesm
Copy link
Member

wesm commented Oct 17, 2017

Also the build is broken, I'm not sure why it passed in your Meson PR but failing now

@kou kou changed the title ARROW-3679: [GLib] Add garrow_record_batch_reader_read_next() ARROW-1679: [GLib] Add garrow_record_batch_reader_read_next() Oct 17, 2017
@kou
Copy link
Member Author

kou commented Oct 17, 2017

Oops, I've fixed title.

Some tests are failed because GObject Introspection on Ubuntu 14.04 is old. I've added version check. It will fix test failures.

@kou
Copy link
Member Author

kou commented Oct 17, 2017

Also the build is broken, I'm not sure why it passed in your Meson PR but failing now

Because I've released a new gobject-introspection gem yesterday. These failed tests has gobject-introspction gem version check (not GObject Introspection itself). These failed tests are enabled with the new gobject-introspection gem.

@wesm
Copy link
Member

wesm commented Oct 17, 2017

thanks!

@asfgit asfgit closed this in 8eb2b0e Oct 17, 2017
@kou kou deleted the glib-record-batch-reader-follow-api-change branch October 18, 2017 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants