ARROW-15511: [Python][C++] Remove reference management in numpy indexer #12314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emkornfield
changed the title
pitrou
approved these changes
Feb 1, 2022
|
Benchmark runs are scheduled for baseline = 0150458 and contender = 3f9daeb. 3f9daeb is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Mar 3, 2022
It appears all usages don't escape the scope of methods so a strong reference should already be in place. This is necessary because Ndarray1DIndexer can be used without the GIL held. Closes apache#12314 from emkornfield/ARROW-15511 Authored-by: emkornfield <emkornfield@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears all usages don't escape the scope of methods so a strong reference should already be in place.
This is necessary because Ndarray1DIndexer can be used without the GIL held.