Skip to content

MINOR: [C++][CI] Pin CMake to fix builds failing due to aws-sdk-cpp #12566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lidavidm wants to merge 1 commit into from
Closed

MINOR: [C++][CI] Pin CMake to fix builds failing due to aws-sdk-cpp #12566

lidavidm wants to merge 1 commit into from

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 4, 2022

westonpace
westonpace approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable workaround and it would be good to get these builds passing again.

@lidavidm
Copy link
Member Author

lidavidm commented Mar 4, 2022

Quick update just to make sure we don't conflict with #12320 (shoulda thought of that ahead of time)

@lidavidm
Copy link
Member Author

lidavidm commented Mar 4, 2022

The CI failure looks unrelated, merging: apache/arrow-rs#1398

@lidavidm lidavidm closed this in 9bd952c Mar 4, 2022
@lidavidm lidavidm deleted the arrow-cmake branch March 4, 2022 19:35
@ursabot
Copy link

ursabot commented Mar 4, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 1b796ec and contender = 9bd952c. 9bd952c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️3.85% ⬆️2.05%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.36%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonpace westonpace westonpace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm @ursabot @westonpace