Skip to content

Conversation

@rouault
Copy link
Contributor

@rouault rouault commented Mar 27, 2022

The initial assertion array->format != NULL refers to a non-existing field. I assume that this was intended to be the release callback

The initial assertion ``array->format != NULL`` refers to a non-existing field. I assume that this was intended to be the release callback
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@rouault rouault changed the title CDataInterface.rst: fix ReleaseExportedArray() example MINOR: [DOC] CDataInterface.rst: fix ReleaseExportedArray() example Mar 27, 2022
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

@kou kou closed this in a589a3d Mar 27, 2022
@ursabot
Copy link

ursabot commented Mar 27, 2022

Benchmark runs are scheduled for baseline = 08bfd4c and contender = a589a3d. a589a3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.13% ⬆️0.04%] test-mac-arm
[Failed ⬇️1.07% ⬆️0.36%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants