-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15431: [Python] Address docstrings in Schema #12783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few small points of feedback
|
Linting is also failing with Not fully sure why that is happening, though (since you didn't change the Parameter sections, and those actually seem to be documented) |
|
This linting error is really strange and also happening on another PR. Will look at it in more detail later today or tomorrow. |
wjones127
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the example data 🦩
Left a few minor suggestions.
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
Benchmark runs are scheduled for baseline = dd42155 and contender = 76d064c. 76d064c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR is adding docstring examples to:
pyarrow.Schemaclass methods and attributes.