Skip to content

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Apr 4, 2022

This PR is adding docstring examples to:

  • pyarrow.Schema class methods and attributes.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few small points of feedback

@jorisvandenbossche
Copy link
Member

Linting is also failing with

 pyarrow.lib.Schema.to_string
-> pyarrow.lib.Schema.to_string(self, truncate_metadata=True, show_field_metadata=True, show_schema_metadata=True)
PR01: Parameters {'show_field_metadata', 'show_schema_metadata'} not documented

pyarrow.lib.Schema.add_metadata
-> pyarrow.lib.Schema.add_metadata(self, metadata)
PR01: Parameters {'metadata'} not documented

Not fully sure why that is happening, though (since you didn't change the Parameter sections, and those actually seem to be documented)

@AlenkaF
Copy link
Member Author

AlenkaF commented Apr 6, 2022

This linting error is really strange and also happening on another PR. Will look at it in more detail later today or tomorrow.

Copy link
Member

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the example data 🦩

Left a few minor suggestions.

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF AlenkaF deleted the ARROW-15431 branch April 8, 2022 07:28
@ursabot
Copy link

ursabot commented Apr 8, 2022

Benchmark runs are scheduled for baseline = dd42155 and contender = 76d064c. 76d064c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.54% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/467| 76d064c7 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/452| 76d064c7 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/453| 76d064c7 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/462| 76d064c7 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/466| dd421557 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/451| dd421557 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/452| dd421557 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/461| dd421557 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants