ARROW-15951: [CI][Python] "Test wheel" step successful despite test error #12844
Conversation
|
|
|
@github-actions crossbow submit wheel-windows-cp310-amd64 |
|
Revision: cde2a45 Submitted crossbow builds: ursacomputing/crossbow @ actions-1833
|
This reverts commit cde2a45.
|
|
||
| @REM Execute unittest | ||
| pytest -r s --pyargs pyarrow || exit /B | ||
| pytest -r s --pyargs pyarrow || exit /B 1 |
There was a problem hiding this comment.
This would probably also have worked:
| pytest -r s --pyargs pyarrow || exit /B 1 | |
| pytest -r s --pyargs pyarrow |
|
@github-actions crossbow submit wheel-windows-cp310-amd64 |
|
@kszucs could you take a look at this? |
|
Revision: 9aba4f2 Submitted crossbow builds: ursacomputing/crossbow @ actions-1834
|
There was a problem hiding this comment.
Nice! Thanks @assignUser for fixing it! (which means making it properly fail in this context)
|
Benchmark runs are scheduled for baseline = 5fa0844 and contender = 58fe60f. 58fe60f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
With no explicit exit code
exit /breturns 0. This made the the step never fail.The failing test is only for demonstration and will of course be removed prior to merging this PR.
I also checked that the same issue isn't happening anywhere else.