Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Apr 22, 2022

  1. Increase timeout to 60 from 40 for macOS and Windows jobs because 40 is short
    to build without ccache cache.
  2. Don't build C++ utilities (ARROW_BUILD_UTILITIES=OFF) because
    they aren't used.
  3. Omit a test for gparquet_row_group_metadata_equal() because
    it seems that parquet::RowGroupMetaData::Equals() is unstable.
    We can look into this later and fix this.

1. Increase timeout to 60 from 40 for macOS job because 40 is short
   to build without ccache cache.
2. Don't build C++ utilities (ARROW_BUILD_UTILITIES=OFF) because
   they aren't used.
3. Omit a test for gparquet_row_group_metadata_equal() because
   it seems that parquet::RowGroupMetaData::Equals() is unstable.
   We can look into this later and fix this.
4. (Optional) Suppress the following warning on Windows by removing
   temporary files explicitly:

   warning: Exception in finalizer #<Tempfile::Remover:0x00000277338b1ad0 @pid=6736, @tmpfile=#<File:D:/a/_temp/data20220422-6736-dotfsz.parquet (closed)>>
   C:/hostedtoolcache/windows/Ruby/3.1.2/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20220422-6736-dotfsz.parquet (Errno::EACCES)
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

kou added 3 commits April 23, 2022 08:24
It seems that finalizer isn't removed with Tempfile#close! on Windows...
We should do this in separated pull request.
@kou
Copy link
Member Author

kou commented Apr 23, 2022

+1

@kou kou closed this in ebc0be2 Apr 23, 2022
@kou kou deleted the ci-glib-stable branch April 23, 2022 00:18
@ursabot
Copy link

ursabot commented Apr 27, 2022

Benchmark runs are scheduled for baseline = 78fb2ed and contender = ebc0be2. ebc0be2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️8.21% ⬆️2.5%] ursa-i9-9960x
[Finished ⬇️1.68% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/604| ebc0be21 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/592| ebc0be21 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/591| ebc0be21 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/602| ebc0be21 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/603| 78fb2edd ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/591| 78fb2edd test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/590| 78fb2edd ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/601| 78fb2edd ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 27, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants