-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-16293: [CI][GLib] Make tests stable #12964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Increase timeout to 60 from 40 for macOS job because 40 is short to build without ccache cache. 2. Don't build C++ utilities (ARROW_BUILD_UTILITIES=OFF) because they aren't used. 3. Omit a test for gparquet_row_group_metadata_equal() because it seems that parquet::RowGroupMetaData::Equals() is unstable. We can look into this later and fix this. 4. (Optional) Suppress the following warning on Windows by removing temporary files explicitly: warning: Exception in finalizer #<Tempfile::Remover:0x00000277338b1ad0 @pid=6736, @tmpfile=#<File:D:/a/_temp/data20220422-6736-dotfsz.parquet (closed)>> C:/hostedtoolcache/windows/Ruby/3.1.2/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20220422-6736-dotfsz.parquet (Errno::EACCES)
|
|
It seems that finalizer isn't removed with Tempfile#close! on Windows...
We should do this in separated pull request.
|
+1 |
|
Benchmark runs are scheduled for baseline = 78fb2ed and contender = ebc0be2. ebc0be2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
to build without ccache cache.
they aren't used.
it seems that parquet::RowGroupMetaData::Equals() is unstable.
We can look into this later and fix this.