Skip to content

Conversation

@westonpace
Copy link
Member

I had not thought to check .travis.yml. The errors appeared to be completely unrelated and I'm still not entirely sure why we receive them. However, in the past, we were not building parquet on the s390x build. With ARROW-16158 we accidentally enabled parquet on this build. This change should disable ARROW_SUBSTRAIT (and transitively, ARROW_PARQUET) so that the behavior is the same as it was before.

@westonpace
Copy link
Member Author

@kou @kszucs Sorry for the trouble, this should get Travis back on track.

@westonpace westonpace changed the title MINOR: [C++] Missed reference to ARROW_ENGINE during the rename ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename Apr 25, 2022
@github-actions
Copy link

@kszucs
Copy link
Member

kszucs commented Apr 25, 2022

No worries, thanks for noticing the problem!

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@ursabot
Copy link

ursabot commented Apr 29, 2022

Benchmark runs are scheduled for baseline = 4a26683 and contender = dcde920. dcde920 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.17% ⬆️0.08%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] dcde920f ec2-t3-xlarge-us-east-2
[Failed] dcde920f test-mac-arm
[Finished] dcde920f ursa-i9-9960x
[Finished] dcde920f ursa-thinkcentre-m75q
[Finished] 4a266834 ec2-t3-xlarge-us-east-2
[Failed] 4a266834 test-mac-arm
[Failed] 4a266834 ursa-i9-9960x
[Finished] 4a266834 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants