Skip to content

ARROW-16206: [Ruby] Add support for DictionaryArray#values, #raw_records with {Month,DayTime,MonthDayNano} Interval Type #13255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
May 30, 2022
Merged

ARROW-16206: [Ruby] Add support for DictionaryArray#values, #raw_records with {Month,DayTime,MonthDayNano} Interval Type #13255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ruby/red-arrow/ext/arrow/converters.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,9 @@ namespace red_arrow {
VISIT(Time32)
VISIT(Time64)
VISIT(Timestamp)
VISIT(MonthInterval)
VISIT(DayTimeInterval)
VISIT(MonthDayNanoInterval)
VISIT(List)
VISIT(Struct)
VISIT(Map)
Expand Down
30 changes: 30 additions & 0 deletions ruby/red-arrow/test/raw-records/test-dictionary-array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,36 @@ def test_decimal256
target = build(Arrow::Decimal256Array.new(data_type, records.collect(&:first)))
assert_equal(records, target.raw_records)
end

def test_month_interval
records = [
[1],
[nil],
[12],
]
target = build(Arrow::MonthIntervalArray.new(records.collect(&:first)))
assert_equal(records, target.raw_records)
end

def test_day_time_interval
records = [
[{day: 1, millisecond: 100}],
[nil],
[{day: 2, millisecond: 300}],
]
target = build(Arrow::DayTimeIntervalArray.new(records.collect(&:first)))
assert_equal(records, target.raw_records)
end

def test_month_day_nano_interval
records = [
[{month: 1, day: 1, nanosecond: 100}],
[nil],
[{month: 2, day: 3, nanosecond: 400}],
]
target = build(Arrow::MonthDayNanoIntervalArray.new(records.collect(&:first)))
assert_equal(records, target.raw_records)
end
end

class RawRecordsRecordBatchDictionaryArraysTest < Test::Unit::TestCase
Expand Down
30 changes: 30 additions & 0 deletions ruby/red-arrow/test/values/test-dictionary-array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,36 @@ def test_decimal256
target = build(Arrow::Decimal256Array.new(data_type, values))
assert_equal(values, target.values)
end

def test_month_interval
values = [
1,
nil,
12,
]
target = build(Arrow::MonthIntervalArray.new(values))
assert_equal(values, target.values)
end

def test_day_time_interval
values = [
{day: 1, millisecond: 100},
nil,
{day: 2, millisecond: 300},
]
target = build(Arrow::DayTimeIntervalArray.new(values))
assert_equal(values, target.values)
end

def test_month_day_nano_interval
values = [
{month: 1, day: 1, nanosecond: 100},
nil,
{month: 2, day: 3, nanosecond: 400},
]
target = build(Arrow::MonthDayNanoIntervalArray.new(values))
assert_equal(values, target.values)
end
end

class ValuesArrayDictionaryArrayTest < Test::Unit::TestCase
Expand Down