ARROW-1852: [C++] Make retrieval of Plasma manager fd a const operation#1352
Conversation
Contributor
|
+1 LGTM! I guess we can merge this without a JIRA via the github ui given how small the patch is? |
Contributor
Author
|
I saw a bunch of open PRs at github, so I just opened one here. Is JIRA a place to do this? |
Member
Member
|
It'd be fine to merge a small patch like this with no JIRA for the changelog, but I created one anyway (@mavam can you let me know your JIRA id so I can assign this to you?) https://issues.apache.org/jira/browse/ARROW-1852 |
Contributor
Author
|
(@wesm My JIRA username is the same as my github handle: mavam.) |
Member
|
Hm, I'm not finding you on the Apache JIRA |
Contributor
|
Great, thanks for the contribution and for merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small patch makes it possible to retrieve the manager fd in a
constcontext. For example:Without this patch, it's impossible to implement the above function.
An alternative would be to simply provide such a utility function as part of
PlasmaClient, but this changes the API. Let me know what you prefer.