Skip to content

ARROW-1852: [C++] Make retrieval of Plasma manager fd a const operation#1352

Closed
mavam wants to merge 1 commit intomasterfrom
unknown repository
Closed

ARROW-1852: [C++] Make retrieval of Plasma manager fd a const operation#1352
mavam wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@mavam
Copy link
Contributor

@mavam mavam commented Nov 23, 2017

This small patch makes it possible to retrieve the manager fd in a const context. For example:

class handle {
public:
  bool connected() const {
    return client_.get_manager_fd() != -1;
  }
private:
  plasma::PlasmaClient client_;
};

Without this patch, it's impossible to implement the above function.

An alternative would be to simply provide such a utility function as part of PlasmaClient, but this changes the API. Let me know what you prefer.

@wesm wesm changed the title Make retrieval of Plasma manager fd a const operation [C++] Make retrieval of Plasma manager fd a const operation Nov 23, 2017
@pcmoritz
Copy link
Contributor

+1 LGTM! I guess we can merge this without a JIRA via the github ui given how small the patch is?

@mavam
Copy link
Contributor Author

mavam commented Nov 24, 2017

I saw a bunch of open PRs at github, so I just opened one here. Is JIRA a place to do this?

@wesm
Copy link
Member

wesm commented Nov 24, 2017

@wesm wesm changed the title [C++] Make retrieval of Plasma manager fd a const operation ARROW-1852: [C++] Make retrieval of Plasma manager fd a const operation Nov 24, 2017
@wesm
Copy link
Member

wesm commented Nov 24, 2017

It'd be fine to merge a small patch like this with no JIRA for the changelog, but I created one anyway (@mavam can you let me know your JIRA id so I can assign this to you?) https://issues.apache.org/jira/browse/ARROW-1852

@wesm wesm closed this in ac4bb69 Nov 24, 2017
@mavam
Copy link
Contributor Author

mavam commented Nov 24, 2017

(@wesm My JIRA username is the same as my github handle: mavam.)

@wesm
Copy link
Member

wesm commented Nov 24, 2017

Hm, I'm not finding you on the Apache JIRA

@pcmoritz
Copy link
Contributor

Great, thanks for the contribution and for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants