ARROW-17273: [Go][CSV] Add Timestamp, Date32, Date64 format support to csv.Writer #13772
Conversation
|
|
| t := w.schema.Field(j).Type.(*arrow.TimestampType) | ||
| for i := 0; i < arr.Len(); i++ { | ||
| if arr.IsValid(i) { | ||
| recs[i][j] = arr.Value(i).ToTime(t.Unit).Format("2006-01-02 15:04:05.999999999") |
There was a problem hiding this comment.
Ideally I'd have TimestampFromStringInLocation but in reverse or FormattedString() like on Date32 or Date64
There was a problem hiding this comment.
you can juts do arr.Value(i).ToTime(t.Unit).In(location).Format(.....) That's why I opted to have it use ToTime, because there's an In method on time.Time to easily shift it to whichever timezone location you need.
|
Benchmark runs are scheduled for baseline = dd96278 and contender = 901e132. 901e132 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Newly supported types
csv.Reader currently supports Timestamps. Not adding Date32/64 support to CSV as the default behavior will stay the same and parse as the broadest
timestamptypehttps://issues.apache.org/jira/browse/ARROW-17273