ARROW-1744: [WIP] Add plasma tensorflow op #1379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holdenk
reviewed
Dec 12, 2017
Contributor
holdenk
left a comment
holdenk
left a comment
There was a problem hiding this comment.
So I'm still new to this project, and my C++ is a little rusty but I had a few questions :)
|
|
||
| zero_out_module = tf.load_op_library('./plasma_op.so') | ||
|
|
||
| client = plasma.connect("/tmp/plasma", "", 64) |
Contributor
There was a problem hiding this comment.
Minor comment, but maybe do a mktemp type thing here instead? I know some folks run tests in parallel on the same machine.
| OP_REQUIRES_OK(context, context->allocate_output(0, shape, &output_tensor)); | ||
| auto output_flat = output_tensor->flat<float>(); | ||
|
|
||
| // Set all but the first element of the output tensor to 0. |
Contributor
There was a problem hiding this comment.
Is this comment perhaps about an older version of the code?
Member
|
@pcmoritz Any progress on this topic here? |
Contributor
Author
|
replaced by #2046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this can be merged, it needs some profiling and comparison to other ways of loading data in TensorFlow.