-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: Update NEWS.md regarding parse_date_time #13791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Update NEWS.md regarding parse_date_time #13791
Conversation
dragosmg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor point
r/NEWS.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any formats we still do not support? With the exception of locale-specific ones on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strftime supports: %a %A %w %d %b %B %m %y %Y %H %I %p %M %z %Z %j %U %W %x %X %% %G %V %u
strptime on Windows supports: "%d", "%H", "%j", "%m", "%T", "%S", "%q", "%M", "%U", "%w", "%W", "%y", "%Y", "%R", "%T"
strptime on non-Windows in additionally supports: "%a", "%A", "%b", "%B", "%Om", "%OS", "%I", "%p", "%r", "%z"
parse_date_time supports on Windows: "H", "I", "j", "M", "S", "U", "w", "W", "y", "Y", "R", "T", "%H", "%I", "%j", "%M", "%S", "%U", "%w", "%W", "%y", "%Y", "%R", "%T"
parse_date_time on non-Windows supports: "a", "A", "b", "B", "Om", "p", "r", "%a", "%A", "%b", "%B", "O%m", "%p", "%r"
I'm not sure where to put this information :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this statement be accurate : "for parse_date_time() we support all formats on Linux and macOS. On windows we don't support ... "? And we stick to parse_date_time() only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Just browsing some old PRs before we're in a release rush...is this PR still relevant/is there anything I can do to put it over the line? |
|
Hey @paleolimbot I'll take a look tomorrow! |
a9781da to
50e3200
Compare
|
@paleolimbot sorry this took a while to get to. Please check if this make sense. |
paleolimbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(Just waiting for CI to do its thing)
|
Benchmark runs are scheduled for baseline = 7492cbe and contender = 611409e. 611409e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Changes introduced by ARROW-16653 were not written up by NEWS.md.