ARROW-1904: [C++] Deprecate PrimitiveArray::raw_values #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eBinary Change-Id: I3cffdee4f6ab8f5e9dc1bc3596edcd345eee70f2
Change-Id: I5c453b4d49389497b0126ec9bd88b36c628b7a63
Member
Author
|
@xhochy this is used in turbodbc, but incorrectly https://github.com/blue-yonder/turbodbc/blob/51970604250e232be709b24e1bde293d37cf9abf/cpp/turbodbc_arrow/Test/tests/arrow_result_set_test.cpp#L65 |
Member
Author
|
This is the last item for 0.8.0, I think. Since this impacts at least one project could you let me know if this is OK? |
Member
|
@wesm as it's only a deprecation, let's merge it as is. |
Member
Author
|
Sweet, thanks! +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was mistaken about this method's handling of the offset parameter, but it doesn't work correctly for boolean data (also a subclass of
PrimitiveArray), so I think it's better to remove this method altogether