Skip to content

Conversation

@thisisnic
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions, but in general looks great!

Reprex with the behaviour I tested:

library(arrow, warn.conflicts = FALSE)
#> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.
library(dplyr, warn.conflicts = FALSE)

example_data <- data.frame(
  chr = letters[1:3],
  dbl = c(1.11, 2.22, 3.33),
  dbl2 = c(4.44, 5.55, 6.66)
)

example_data |> 
  as_arrow_table() |> 
  transmute(across(c(dbl, dbl2), round)) |> 
  collect()
#>   dbl dbl2
#> 1   1    4
#> 2   2    6
#> 3   3    7

Created on 2022-10-04 by the reprex package (v2.0.1)


test_that("Can use across() within transmute()", {

# expressions work in the right order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this comment is trying to say...maybe remove it (or clarify it if it's important)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

@thisisnic thisisnic merged commit eb5f0f7 into apache:master Oct 6, 2022
@ursabot
Copy link

ursabot commented Oct 6, 2022

Benchmark runs are scheduled for baseline = d31f3d9 and contender = eb5f0f7. eb5f0f7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] eb5f0f78 ec2-t3-xlarge-us-east-2
[Failed] eb5f0f78 test-mac-arm
[Failed] eb5f0f78 ursa-i9-9960x
[Finished] eb5f0f78 ursa-thinkcentre-m75q
[Finished] d31f3d94 ec2-t3-xlarge-us-east-2
[Failed] d31f3d94 test-mac-arm
[Failed] d31f3d94 ursa-i9-9960x
[Finished] d31f3d94 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants