ARROW-2029: [Python] NativeFile.tell errors after close #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was subclass specific, and wasn't caught in the hdfs backed file, leading to program crashes. Adds a check in `NativeFile.tell` for the file being open, and a test on a few subclasses of `NativeFile` to assure the error is raised.
wesm
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously checking if the file was closed was subclass specific, and wasn't caught in the hdfs backed file, leading to program crashes.
This adds a check in
NativeFile.tellfor the file being open, and a test on a few subclasses ofNativeFileto assure the error is raised.Note that since most python file-like objects raise a
ValueErrorfor operations after close, I changed the type of the existing error for these cases. This could be changed back, but an error should at least be thrown.