ARROW-2047: [Python] Use sys.executable instead of one in the search path. #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jan 30, 2018
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
This looks reasonable to me. Are there other places in the test suite using the same pattern?
wesm
approved these changes
Jan 30, 2018
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1. This is the only place I can see where Python itself is being invoked in the test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.check_call()that searches for the executable in the search path. Because of it, the test run needs a valid search path setup.