ARROW-1861: [Python] Rework benchmark suite [skip ci]#1543
ARROW-1861: [Python] Rework benchmark suite [skip ci]#1543pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
08bb9db to
21cc1e3
Compare
|
Now ready for review. |
21cc1e3 to
41268ee
Compare
There was a problem hiding this comment.
Can you dedent this 4 spaces.
python/benchmarks/array_ops.py
Outdated
There was a problem hiding this comment.
I wonder if this should loop over the array with elements already indexed so that we don't have to compute the difference between time_getitem and time_getitem_as_py to see the overhead of as_py. Something like
for el in self._array2:
el.as_py()There was a problem hiding this comment.
Then we'll be benchmarking array iteration ;-) Instead I think I'll store the list of indexed values in the setup() method.
There was a problem hiding this comment.
Note we may want to benchmark as_py() on different types.
(though the inner machinery may already be exercised as part of to_pylist?)
python/asv.conf.json
Outdated
There was a problem hiding this comment.
Probably ok to blow away the commented out things
41268ee to
0d74ce2
Compare
|
By the way, do you have any ideas for further benchmarks? |
0d74ce2 to
b608579
Compare
This PR focusses on: