Skip to content

ARROW-2124: [Python] Add test for empty item in array#1586

Closed
xhochy wants to merge 1 commit intoapache:masterfrom
xhochy:ARROW-2124
Closed

ARROW-2124: [Python] Add test for empty item in array#1586
xhochy wants to merge 1 commit intoapache:masterfrom
xhochy:ARROW-2124

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Feb 11, 2018

No description provided.

@xhochy
Copy link
Member Author

xhochy commented Feb 12, 2018

@pitrou your change detection script fails here, can you have a short look what the problem may be?

@pitrou
Copy link
Member

pitrou commented Feb 12, 2018

@xhochy My guess is that you force-pushed in the meantime, for example after rebasing, and therefore the original changeset doesn't exist in the repo anymore? I will try to make this more robust.

@pitrou
Copy link
Member

pitrou commented Feb 12, 2018

See #1590

@wesm
Copy link
Member

wesm commented Feb 12, 2018

Rebased

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xhochy
Copy link
Member Author

xhochy commented Feb 12, 2018

@pitrou yes, I'm a frequent rebaser and force-pusher :D

@wesm
Copy link
Member

wesm commented Feb 12, 2018

Appveyor build running here https://ci.appveyor.com/project/xhochy/arrow/build/1.0.572. I will merge once that advances some more

fix flakes

Change-Id: I519f52680f4aea85a76d45df2dbf30e3b3133c3b
@wesm wesm closed this in 30ab43f Feb 12, 2018
@wesm wesm deleted the ARROW-2124 branch February 12, 2018 21:25
@wesm
Copy link
Member

wesm commented Feb 12, 2018

thanks @xhochy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants