ARROW-2138: [C++] abort on failed debug check#1595
Closed
pitrou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-2138: [C++] abort on failed debug check#1595pitrou wants to merge 1 commit intoapache:masterfrom
pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
Using abort() instead of exit(1) triggers debug tools such as gdb and therefore makes debugging easier.
xhochy
approved these changes
Feb 12, 2018
Member
|
restarted the failed travis builds |
Member
Author
|
AppVeyor build started at https://ci.appveyor.com/project/pitrou/arrow/build/1.0.68 |
Member
|
OK, the Windows builds look fine. I'm merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using abort() instead of exit(1) triggers debug tools such as gdb and therefore makes debugging easier.