New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2138: [C++] abort on failed debug check #1595

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@pitrou
Contributor

pitrou commented Feb 12, 2018

Using abort() instead of exit(1) triggers debug tools such as gdb and therefore makes debugging easier.

ARROW-2138: [C++] abort on failed debug check
Using abort() instead of exit(1) triggers debug tools such as gdb
and therefore makes debugging easier.
@wesm

wesm approved these changes Feb 12, 2018

+1

@xhochy

xhochy approved these changes Feb 12, 2018

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Feb 12, 2018

Member

restarted the failed travis builds

Member

wesm commented Feb 12, 2018

restarted the failed travis builds

@pitrou

This comment has been minimized.

Show comment
Hide comment
@pitrou
Contributor

pitrou commented Feb 12, 2018

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Feb 12, 2018

Member

OK, the Windows builds look fine. I'm merging this

Member

wesm commented Feb 12, 2018

OK, the Windows builds look fine. I'm merging this

@wesm wesm closed this in cf00b57 Feb 12, 2018

@pitrou pitrou deleted the pitrou:ARROW-2138-abort-on-debug-check branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment