ARROW-2209: [Python] Partition columns are not correctly loaded in schema of ParquetDataset#1656
Closed
xhochy wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-2209: [Python] Partition columns are not correctly loaded in schema of ParquetDataset#1656xhochy wants to merge 3 commits intoapache:masterfrom
xhochy wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
Necessary fixes for the |
3 tasks
…hema of ParquetDataset
cpcloud
reviewed
Feb 26, 2018
python/pyarrow/types.pxi
Outdated
| def get_field_index(self, name): | ||
| return self.schema.GetFieldIndex(tobytes(name)) | ||
|
|
||
| def add_field(self, int i, Field field): |
Contributor
There was a problem hiding this comment.
This feels like just a wrapping of the C++ API. Is there an API that we can provide that'll be more familiar to Python users? How about insert/append/remove similar to lists?
Member
There was a problem hiding this comment.
Either way I think these methods need to return new objects, so Schema is not mutable like list, though
Contributor
There was a problem hiding this comment.
Sure. I don't think the semantics need to be identical, but I think the spelling can be improved.
Member
Author
There was a problem hiding this comment.
As this is most similar to a list, I would use the function names as defined there but would do some adjustments, e.g.:
- Always return a new object
- Use indices instead of actual values, i.e. "
remove(x)would beremove(i)".
Member
Author
|
Adjusted the API to be more like a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.