ARROW-2292: [Python] Rename frombuffer() to py_buffer()#1736
Closed
pitrou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-2292: [Python] Rename frombuffer() to py_buffer()#1736pitrou wants to merge 1 commit intoapache:masterfrom
pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
wesm
reviewed
Mar 12, 2018
python/pyarrow/io.pxi
Outdated
Member
There was a problem hiding this comment.
I thought DeprecationWarning does not show up by default. FutureWarning instead?
Member
Author
There was a problem hiding this comment.
Not by default, though it will show up in interactive settings such as IPython. I can switch to FutureWarning if you prefer.
wesm
force-pushed
the
ARROW-2292-py_buffer
branch
from
734cdab to
41bf5f8
Compare
Member
|
I tweaked to use the deprecation wrapper-maker and use FutureWarning (so this will show up even in non-interactive code -- this is the convention we've been using in pandas for visible deprecations so people should be used to it by now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.