ARROW-2407: [GLib] Add garrow_string_array_builder_append_values() #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
reviewed
Apr 6, 2018
c_glib/arrow-glib/array-builder.cpp
Outdated
Member
There was a problem hiding this comment.
Missing word: … It's more efficient …
c_glib/arrow-glib/array-builder.cpp
Outdated
Member
There was a problem hiding this comment.
Converting to std::string and inserting then into the Builder is still not the most efficient way, it would be better if we could directly pass the values to the StringBuilder instance. This has not be in this PR but I made a JIRA about that: https://issues.apache.org/jira/browse/ARROW-2411
Member
Author
There was a problem hiding this comment.
It makes sense.
I'll create a pull request.
Member
|
@kou feel free to merge or rebase on the newly added Append method. |
kou
force-pushed
the
glib-string-array-builder-append
branch
from
e7c35f3 to
5bc6e8d
Compare
Member
Author
|
OK. If CI is passed, I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.