ARROW-2369: [Python] Fix reading large Parquet files (> 4 GB)#1866
Closed
pitrou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-2369: [Python] Fix reading large Parquet files (> 4 GB)#1866pitrou wants to merge 1 commit intoapache:masterfrom
pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
Member
pitrou
commented
Apr 9, 2018
pitrou
commented
- Fix PythonFile.seek() for offsets > 4 GB
- Avoid instantiating a PythonFile in ParquetFile, for efficiency
- Fix PythonFile.seek() for offsets > 4 GB - Avoid instantiating a PythonFile in ParquetFile, for efficiency
xhochy
approved these changes
Apr 12, 2018
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, this looks good as the test seems to work but even when it's merged, I would appreciate a short explanantion what the bug was in the end.
| Status Seek(int64_t position, int whence) { | ||
| // whence: 0 for relative to start of file, 2 for end of file | ||
| PyObject* result = cpp_PyObject_CallMethod(file_, "seek", "(ii)", position, whence); | ||
| PyObject* result = cpp_PyObject_CallMethod(file_, "seek", "(ni)", |
Member
There was a problem hiding this comment.
Problem was before that position was casted to an int32?
Member
Author
There was a problem hiding this comment.
Yes, i takes the given parameter as int while n takes it as Py_ssize_t.
Member
Author
There was a problem hiding this comment.
Ultimately it is the same format string syntax as documented here: https://docs.python.org/3/c-api/arg.html#building-values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.