Skip to content

ARROW-1928: [C++] Add BitmapReader/BitmapWriter benchmarks#1915

Closed
pitrou wants to merge 1 commit intoapache:masterfrom
pitrou:ARROW-1928-bitmap-benchmarks
Closed

ARROW-1928: [C++] Add BitmapReader/BitmapWriter benchmarks#1915
pitrou wants to merge 1 commit intoapache:masterfrom
pitrou:ARROW-1928-bitmap-benchmarks

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Apr 19, 2018

Also improve the BitmapWriter implementation (around 18% faster here - on Ubuntu 16.04 with gcc 4.9).

I experimented with a different implementation for BitmapReader (storing the bit mask instead of the bit offset), but it came out surprisingly slower.

@pitrou pitrou force-pushed the ARROW-1928-bitmap-benchmarks branch 2 times, most recently from 5c5cd6b to e9b50f0 Compare April 19, 2018 15:03
Also improve the BitmapWriter implementation (around 18% faster here)
@pitrou pitrou force-pushed the ARROW-1928-bitmap-benchmarks branch from e9b50f0 to 733cc81 Compare April 19, 2018 15:07
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Apr 19, 2018

Benchmark numbers here:

BM_NaiveBitmapReader/97.6562k/min_time:1.000       1391 us       1390 us       1016   137.181MB/s
BM_BitmapReader/97.6562k/min_time:1.000            1162 us       1162 us       1139   164.143MB/s
BM_NaiveBitmapWriter/97.6562k/min_time:1.000       1299 us       1299 us       1077   146.872MB/s
BM_BitmapWriter/97.6562k/min_time:1.000            1032 us       1032 us       1358    184.88MB/s

The original BitmapWriter implementation achieved 155MB/s.

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

🚄!

@xhochy xhochy closed this in 249e039 Apr 21, 2018
@pitrou pitrou deleted the ARROW-1928-bitmap-benchmarks branch April 21, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants