ARROW-2593: [Python] TypeError: data type "mixed-integer" not understood#2084
Closed
kszucs wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-2593: [Python] TypeError: data type "mixed-integer" not understood#2084kszucs wants to merge 2 commits intoapache:masterfrom
kszucs wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2084 +/- ##
==========================================
- Coverage 86.35% 86.33% -0.02%
==========================================
Files 242 230 -12
Lines 41184 40297 -887
==========================================
- Hits 35564 34791 -773
+ Misses 5620 5506 -114
Continue to review full report at Codecov.
|
wesm
approved these changes
May 29, 2018
Member
wesm
left a comment
There was a problem hiding this comment.
+1. I think it's OK to coerce the integer to a string for now. If round-tripping this data faithfully becomes a problem, we can dig more into solutions later on
xhochy
approved these changes
May 29, 2018
Member
xhochy
left a comment
There was a problem hiding this comment.
+1, LGTM
I'm also happy with coercing to string at the moment.
|
pyarrow upgrade to 0.15.1 fixed this issue. with 0.9.0 his issue remains unresolved. |
Member
|
Right, the first release that contained this fix was 0.10.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
nameandfield_nameis enforced to be a string, but that way we lose the type of it (an integer in this case).Could We use one of it to preserve the original type of the column name?