Skip to content

ARROW-2727: [Java] Fix POM file issue causing build failure in java/adapters/jdbc#2151

Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ARROW-2727
Closed

ARROW-2727: [Java] Fix POM file issue causing build failure in java/adapters/jdbc#2151
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ARROW-2727

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jun 21, 2018

It only happens when building arrow java the first time. If you have installed arrow in local before, you won't see this issue. This issue is due to the pom file issue.

@wesm wesm changed the title ARROW-2727. Unable to build java module ARROW-2727: [Java] Unable to build java module Jun 21, 2018
@wesm wesm changed the title ARROW-2727: [Java] Unable to build java module ARROW-2727: [Java] Fix POM file issue causing build failure in java/adapters/jdbc Jun 21, 2018
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this module not being built in Travis CI? I'm curious why this failure did not show up there

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 21, 2018

Here's what I see, this module is built in this PR's travis (https://api.travis-ci.org/v3/job/394900005/log.txt) . But I don't see it in another PR's travis (https://api.travis-ci.org/v3/job/394900005/log.txt).

@BryanCutler
Copy link
Member

BryanCutler commented Jun 25, 2018

I was able to reproduce after deleting the pom from my local repo
edit - just to clarify, this occurs when the jdbc/pom.xml can not find the parent pom

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zjffdu , this fixes the issue but I'd prefer including the parent pom.xml in the path

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more used to specifying this as ../../pom.xml, would you mind changing to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@codecov-io
Copy link

Codecov Report

Merging #2151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2151   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         230      230           
  Lines       40706    40706           
=======================================
  Hits        35167    35167           
  Misses       5539     5539

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0e521...07ddb57. Read the comment docs.

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryanCutler
Copy link
Member

merged to master, thanks @zjffdu !

@BryanCutler
Copy link
Member

@wesm or @xhochy , could you please give Jeff Zhang the permission to get issues assigned?

@wesm
Copy link
Member

wesm commented Jun 26, 2018

I opened https://issues.apache.org/jira/browse/ARROW-2743; I think we should address the Travis CI issue

@wesm
Copy link
Member

wesm commented Jun 26, 2018

I made Jeff a contributor and assigned the issue to him

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…dapters/jdbc

It only happens when building arrow java the first time. If you have installed arrow in local before, you won't see this issue. This issue is due to the pom file issue.

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#2151 from zjffdu/ARROW-2727 and squashes the following commits:

07ddb57 <Jeff Zhang> ARROW-2727:  Fix POM file issue causing build failure in java/adapters/jdbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants