ARROW-2344: [Go] Run Go unit tests in Travis CI

[sbinet]

No description provided.

[codecov-io]

Codecov Report

Merging #2193 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   86.47%   86.47%   -0.01%     
==========================================
  Files         244      244              
  Lines       41808    41835      +27     
==========================================
+ Hits        36155    36178      +23     
- Misses       5653     5657       +4

Impacted Files	Coverage Δ
cpp/src/arrow/python/helpers.cc	79.87% <0%> (-3.23%)	⬇️
cpp/src/arrow/python/common.h	100% <0%> (ø)	⬆️
cpp/src/arrow/python/python_to_arrow.cc	88.29% <0%> (+0.12%)	⬆️
cpp/src/arrow/python/arrow_to_python.cc	91.71% <0%> (+0.2%)	⬆️
cpp/src/arrow/python/builtin_convert.cc	92.1% <0%> (+0.47%)	⬆️
cpp/src/arrow/util/thread-pool-test.cc	99.45% <0%> (+0.54%)	⬆️
cpp/src/arrow/python/helpers.h	90% <0%> (+1.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ce215...a2dd243. Read the comment docs.

[wesm]

Thanks @sbinet! We should also integrate this into https://github.com/apache/arrow/blob/master/ci/detect-changes.py so the Go tests are only run when there is a Go change.

[sbinet]

should I integrate this into this PR or should I create a JIRA ticket+new PR ?

[wesm]

You can do it here, no problem

[sbinet]

Ok. PTAL.

[sbinet]

not sure why appveyor failed (in C++, I think) nor why suddenly the travis-ruby test failed (loading some lua library)...

[sbinet]

(but this seems unrelated to my change.)

[xhochy]

Can you add a line - if [ $ARROW_CI_GO_AFFECTED != "1" ]; then exit; fi here so that the Go build only runs for GO PRs?

[sbinet]

Sure. Will do when in front of a real keyboard.

[wesm]

Rebased and added that

[sbinet]

@wesm thanks!

the travis issue seems unrelated.

[pitrou]

@sbinet yes, the test_use_huge_pages failure in unrelated.

[pitrou]

+1. Thanks for doing this @sbinet !

[pitrou]

Just for my personal enlightenment: when go install runs in 0.10s, is it really the entire build time for Arrow? :-o

[sbinet]

Yep. Go builds really fast. :)
(Also, Go arrow is rather bare bones for now...)

[wesm]

The way I look at Go, it's Google's reaction to a decade of production C++ development. A lot of Google C++ best practices are reflected in the language itself, and the difference in compiler speed of course is a stark difference to large C++ projects