Skip to content

ARROW-2809: [C++] Only print cpplint and clang-format output for failures by default#2229

Closed
wesm wants to merge 1 commit intoapache:masterfrom
wesm:ARROW-2809
Closed

ARROW-2809: [C++] Only print cpplint and clang-format output for failures by default#2229
wesm wants to merge 1 commit intoapache:masterfrom
wesm:ARROW-2809

Conversation

@wesm
Copy link
Copy Markdown
Member

@wesm wesm commented Jul 7, 2018

I added a ARROW_VERBOSE_LINT CMake option so this can be turned on and off. This helps trim down on the verbosity in our Travis CI logs

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Merge on green

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2229 into master will increase coverage by 2.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
+ Coverage    84.1%   86.54%   +2.43%     
==========================================
  Files         288      232      -56     
  Lines       43865    41181    -2684     
==========================================
- Hits        36892    35639    -1253     
+ Misses       6942     5542    -1400     
+ Partials       31        0      -31
Impacted Files Coverage Δ
python/pyarrow/pandas_compat.py 97.85% <0%> (ø) ⬆️
go/arrow/array/builder.go
go/arrow/memory/memory.go
rust/src/buffer.rs
go/arrow/memory/memory_sse4_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/array/bufferbuilder_numeric.gen.go
go/arrow/datatype_fixedwidth.go
go/arrow/type_traits_numeric.gen.go
go/arrow/math/int64.go
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836afac...292b6e2. Read the comment docs.

@xhochy xhochy closed this in ae5e4b8 Jul 8, 2018
@xhochy xhochy deleted the ARROW-2809 branch July 8, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants