ARROW-2841: [Go] support building in forks#2261
Closed
sbinet wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Go is pretty adamant about where source code needs to be. A package named "github.com/apache/arrow/go" needs to be checked out under $GOPATH/src/github.com/apache/arrow/go, otherwise wires get crossed. Fortunately, Travis-CI has some support to allow checking out a repository github.com/foo/bar under example.com/foo/bar (this is for the so-called "vanity imports.") Reuse this facility for the forks.
Contributor
Author
|
@pitrou do you want to give it a try in your fork? |
Member
|
I'm happy to help test in my fork, but still failing here, though |
Member
|
Here's a build I just kicked off https://travis-ci.org/wesm/arrow/builds/403571049 |
Member
|
Oh looks like a non-Go failure =) Let's see if it passes in my fork |
Contributor
Author
|
Looks like it's building Go correctly :) |
wesm
approved these changes
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go is pretty adamant about where source code needs to be.
A package named "github.com/apache/arrow/go" needs to be checked out
under $GOPATH/src/github.com/apache/arrow/go, otherwise wires get
crossed.
Fortunately, Travis-CI has some support to allow checking out a repository
github.com/foo/bar
under
example.com/foo/bar
(this is for the so-called "vanity imports.")
Reuse this facility for the forks.