Skip to content

ARROW-2711: [Python] Fix inference from Pandas column with first empty list#2309

Closed
pitrou wants to merge 2 commits intoapache:masterfrom
pitrou:ARROW-2711-infer-empty-list
Closed

ARROW-2711: [Python] Fix inference from Pandas column with first empty list#2309
pitrou wants to merge 2 commits intoapache:masterfrom
pitrou:ARROW-2711-infer-empty-list

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Jul 23, 2018

No description provided.

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2309 into master will increase coverage by 2.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   84.37%   86.76%   +2.39%     
==========================================
  Files         293      237      -56     
  Lines       44741    42008    -2733     
==========================================
- Hits        37749    36449    -1300     
+ Misses       6961     5559    -1402     
+ Partials       31        0      -31
Impacted Files Coverage Δ
cpp/src/arrow/python/numpy_to_arrow.cc 89.08% <100%> (+0.02%) ⬆️
python/pyarrow/tests/test_convert_pandas.py 94.92% <100%> (+0.02%) ⬆️
rust/src/builder.rs
go/arrow/array/numericbuilder.gen.go
rust/src/list.rs
go/arrow/array/util.go
go/arrow/array/bufferbuilder.go
go/arrow/datatype_fixedwidth.go
go/arrow/array/bufferbuilder_byte.go
go/arrow/array/bufferbuilder_numeric.gen.go
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355ff08...859ca93. Read the comment docs.

@pitrou pitrou closed this in 141b2c3 Jul 23, 2018
@pitrou pitrou deleted the ARROW-2711-infer-empty-list branch July 23, 2018 16:53
@wesm
Copy link
Copy Markdown
Member

wesm commented Jul 23, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants