Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Aug 6, 2018

This omits all warning and debug logs from previous Maven output.

@pitrou
Copy link
Member Author

pitrou commented Aug 6, 2018

@xhochy

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @pitrou! It's a little bit disappointing; I was hoping the active Java developers would do some work to improve the messy build, but this will do for now. Merge on green

@codecov-io
Copy link

Codecov Report

Merging #2378 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
- Coverage   84.51%   84.49%   -0.03%     
==========================================
  Files         293      293              
  Lines       45329    45329              
==========================================
- Hits        38312    38301      -11     
- Misses       6990     6997       +7     
- Partials       27       31       +4
Impacted Files Coverage Δ
go/arrow/math/float64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/int64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_amd64.go 28.57% <0%> (-14.29%) ⬇️
go/arrow/math/math_amd64.go 31.57% <0%> (-5.27%) ⬇️
cpp/src/arrow/util/thread-pool-test.cc 98.91% <0%> (-0.55%) ⬇️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992b27f...603db64. Read the comment docs.

@pitrou pitrou closed this in d9d1f6b Aug 6, 2018
@pitrou pitrou deleted the ARROW-2815-strip-java-logging branch August 6, 2018 17:11
wesm pushed a commit that referenced this pull request Aug 6, 2018
…pveyor]

This omits all warning and debug logs from previous Maven output.

Author: Antoine Pitrou <antoine@python.org>

Closes #2378 from pitrou/ARROW-2815-strip-java-logging and squashes the following commits:

603db64 <Antoine Pitrou> ARROW-2815:  Skip Java tests and style checks on C++ job
mvn -B install
if [ $ARROW_TRAVIS_JAVA_BUILD_ONLY == "1" ]; then
# Save time and make build less verbose by skipping tests and style checks
mvn -DskipTests=true -Dcheckstyle.skip=true -B install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pitrou you could use --quiet that will output nothing unless there is an error. Want me to add that? Also, if you still want to run tests here, using #2465 will change the log level to get rid of the debug messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants