ARROW-3214: [C++] Disable insecure warnings in MinGW build #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already disabled in MSVC build.
Member
Author
|
You can see the important changes easily by disabling whitespace changes by https://github.com/apache/arrow/pull/2539/files?w=1 . |
kou
changed the title
pitrou
requested changes
Sep 11, 2018
| set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /bigobj") | ||
| # Support large object code | ||
| set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /bigobj") | ||
| endif() |
Member
There was a problem hiding this comment.
Writing this as endif(MSVC) would make things easier to follow, IMHO.
Member
Author
There was a problem hiding this comment.
That makes sense.
I've added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already disabled in MSVC build.