Skip to content

ARROW-3319: [GLib] Add align() to GArrowInputStream and GArrowOutputStream #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kou wants to merge 2 commits into from
Closed

ARROW-3319: [GLib] Add align() to GArrowInputStream and GArrowOutputStream #2626

kou wants to merge 2 commits into from

Conversation

@kou
Copy link
Member

@kou kou commented Sep 25, 2018

No description provided.

@kou
Copy link
Member Author

kou commented Sep 25, 2018

@shiro615 Can you review this?

@wesm
Copy link
Member

wesm commented Sep 25, 2018

It occurred to me that we could make these methods OutputStream::Align or InputStream::Align instead of top level functions. Do you have an opinion?

@kou
Copy link
Member Author

kou commented Sep 25, 2018 •
edited
Loading

InputStream::Align() and OutputStream::Align() are natural in object oriented API.
But the current AlignStream() in ipc/ isn't bad because this functionality is for IPC.

So both InputStream::Align() and AlignStream() in ipc/ are natural to me.

In Arrow GLib API, I prefer object oriented API because it's natural in Ruby. (Arrow GLib API is mapped to Arrow Ruby API automatically.)

shiro615
shiro615 reviewed Sep 26, 2018
View reviewed changes
c_glib/test/test-buffer-input-stream.rb Outdated
def test_align
buffer = Arrow::Buffer.new("Hello World")
buffer_input_stream = Arrow::BufferInputStream.new(buffer)
buffer_input_stream.advance(8)
Copy link
Contributor

@shiro615 shiro615 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps should we test with align () ?

Copy link
Member Author

@kou kou Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Good catch!
I've fixed this.

shiro615
shiro615 approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kou
Copy link
Member Author

kou commented Sep 26, 2018

Thanks! I'll merge this.

@kou kou closed this in 9d007b1 Sep 26, 2018
@kou kou deleted the glib-add-align-to-stream branch September 26, 2018 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiro615 shiro615 shiro615 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou @wesm @shiro615